New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-297][iOS] fix iOS 11 save image permission #1119

Merged
merged 1 commit into from Apr 20, 2018

Conversation

Projects
None yet
4 participants
@PhilCai1993

PhilCai1993 commented Apr 19, 2018

From iOS 11, NSPhotoLibraryAddUsageDescription is required in info.plist to save image to album.

Bug 297

@weex-bot

This comment has been minimized.

weex-bot commented Apr 19, 2018

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

@acton393

This comment has been minimized.

Member

acton393 commented Apr 19, 2018

hi thanks for your carefully finding the bug @PhilCai1993

you can rebase your branch to this repository master branch or just check out a new branch based on the master branch, I see another old change on this pull request.

@PhilCai1993

This comment has been minimized.

PhilCai1993 commented Apr 20, 2018

rebased @acton393

@acton393

This comment has been minimized.

Member

acton393 commented Apr 20, 2018

@PhilCai1993 thanks for your contribution , it will be accepted.

@asfgit asfgit merged commit 14dbdc4 into apache:master Apr 20, 2018

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment