Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-445][jsfm] export requireModule to global #1254

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
4 participants
@imyzf
Copy link
Contributor

commented Jun 8, 2018

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

This is a API for internal usage, so no test and no doc update.

@weex-bot

This comment has been minimized.

Copy link

commented Jun 8, 2018

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

@@ -117,6 +117,7 @@ function createInstanceContext (id, options = {}, data) {
Object.assign(runtimeContext, services, {
weex,
getJSFMVersion,
requireModule: weex.requireModule,

This comment has been minimized.

Copy link
@Hanks10100

Hanks10100 Jun 26, 2018

Contributor

I think using (..args) => weex.requireModule(...args) is more reliable. We should not assume that the context of requireModule has bind to weex even if it actually does.

This comment has been minimized.

Copy link
@imyzf

imyzf Jun 27, 2018

Author Contributor

done.

@imyzf imyzf force-pushed the imyzf:feature/require-module branch from 5d2d1bc to aebd432 Jun 27, 2018

@asfgit asfgit merged commit aebd432 into apache:master Jun 27, 2018

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.