This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-445][jsfm] export requireModule to global #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
Hanks10100
reviewed
Jun 26, 2018
runtime/api/init.js
Outdated
| @@ -117,6 +117,7 @@ function createInstanceContext (id, options = {}, data) { | |||
| Object.assign(runtimeContext, services, { | |||
| weex, | |||
| getJSFMVersion, | |||
| requireModule: weex.requireModule, | |||
There was a problem hiding this comment.
I think using (..args) => weex.requireModule(...args) is more reliable. We should not assume that the context of requireModule has bind to weex even if it actually does.
imyzf
force-pushed
the
feature/require-module
branch
from
5d2d1bc
to
aebd432
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution!
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
CheckList:
if isBugFix :
elif isNewFeature :
This is a API for internal usage, so no test and no doc update.