New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-465][Android]fix performance point interactionTime record bug #1278

Merged
merged 1 commit into from Jun 20, 2018

Conversation

Projects
None yet
3 participants
@lucky-chen
Contributor

lucky-chen commented Jun 20, 2018

  • use jsCreateFinish flag to replace mEnd
  • call onElementChanged() just in add/rm element action
  • proteted mWXSDKInstance.getWXPerformance() null ptr
@weex-bot

This comment has been minimized.

weex-bot commented Jun 20, 2018

Warnings
⚠️ No Changelog changes!
⚠️ Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/module/WXTimerModule.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
⚠️ Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
Messages
📖 danger test finished.

Generated by 🚫 dangerJS

@asfgit asfgit merged commit dc1936e into apache:master Jun 20, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment