Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

* [android] fix reload jsservice bug #1318

Closed

Conversation

jiangxiang89
Copy link

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link

weex-bot commented Jul 11, 2018

Fails
🚫 Failed to run assembleDebug task for android.
Messages
📖 android build verification finished.

Generated by 🚫 dangerJS

Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are in the else case, I think there is Application object therefore no reason to invoke WXServiceManager.execAllCacheJsService();

@YorkShen
Copy link
Contributor

I will close this PR, feel free to reopen if you have problem.

@YorkShen YorkShen closed this Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants