Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-547][jsfm] Remove module proxy cache of weex.requireModule #1389

Merged
merged 1 commit into from Aug 2, 2018

Conversation

Projects
None yet
3 participants
@Hanks10100
Copy link
Contributor

commented Aug 2, 2018

JS Framework has a cache strategy for module proxies which is good for performance. But it also a potential reason for the memory leak.

@weex-bot

This comment has been minimized.

Copy link

commented Aug 2, 2018

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

@imyzf

imyzf approved these changes Aug 2, 2018

@Hanks10100 Hanks10100 merged commit 053f26e into apache:master Aug 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

yxping added a commit to yxping/incubator-weex that referenced this pull request Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.