This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-558][Android] Font file url compatible with ' and " #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
YorkShen
reviewed
Aug 14, 2018
| @@ -73,7 +73,7 @@ private void parseSrc(String src, WXSDKInstance instance) { | |||
| return; | |||
| } | |||
|
|
|||
| if (src.matches("^url\\('.*'\\)$")) { | |||
| if (src.matches("^url\\((('[^']*')|(\"[^\"]*\"))\\)$")) { | |||
There was a problem hiding this comment.
Why not use ^url\\((('.*')|(\".*\"))\\)$ ?
There was a problem hiding this comment.
My idea is that no quotes are allowed inside http url.
Maybe you are right, without this restriction will get better compatibility.
Would you like me to change the code?
|
@YorkShen I have changed the regex to allow quotes inside the url of font file |
Darin726
pushed a commit
to Darin726/incubator-weex
that referenced
this pull request
Sep 12, 2018
* apache/master: [WEEX-558][Android] Font file url compatible with ' and " (apache#1419)
Darin726
pushed a commit
to Darin726/incubator-weex
that referenced
this pull request
Sep 12, 2018
…o merge_all_code * 'merge_all_code' of gitlab.alibaba-inc.com:weex/weex: [core] fix data render ref problem [core] update so [core] fix JNI pinned array reference table overflow [core] miss file in cmakelist [core] fix string add sequence problem [Android] fix WXHeader sticky problem [WEEX-558][Android] Font file url compatible with ' and " (apache#1419)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://issues.apache.org/jira/browse/WEEX-558
use costumer fontFace like this:
double quotes is outside for font file url, it will make an error with lint.
when set as this, the font face does not work with android:
it cause by FontDO