This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-566][Android] add jsb version file to make jsb.so can update #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
YorkShen
suggested changes
Aug 15, 2018
| if(newfile.exists() && versionFile.exists()) { | ||
| try { | ||
| FileReader fileReader = new FileReader(versionFile); | ||
| BufferedReader br = new BufferedReader(fileReader); |
There was a problem hiding this comment.
Invoke br.close when finishing reading file
| versionFile.createNewFile(); | ||
| FileWriter fileWriter = new FileWriter(versionFile); | ||
| fileWriter.write(String.valueOf(WXEnvironment.CORE_JSB_SO_VERSION)); | ||
| fileWriter.flush(); |
There was a problem hiding this comment.
Add a more try catch finally clause to close the writer as if there is a exception in line 268, fileWriter would be still open.
Darin726
force-pushed
the
ApacheMaster-1
branch
from
da2847f
to
d9ad97b
Compare
YorkShen
suggested changes
Aug 16, 2018
| if(!versionFile.exists()) | ||
| versionFile.createNewFile(); | ||
| FileWriter fileWriter = new FileWriter(versionFile); | ||
| fileWriter.write(String.valueOf(WXEnvironment.CORE_JSB_SO_VERSION)); |
There was a problem hiding this comment.
If line 277 crashes, the file will still be open.
FileWriter x = null
try{
x= new FileWriter
}finally{
if(x != null) x.close()
}
add jsb version file to make jsb.so can update
Bug: WEEX-566
[WEEX-566][Android] add jsb version file to make jsb.so can update
add jsb version file to make jsb.so can update
Bug: WEEX-566
Darin726
force-pushed
the
ApacheMaster-1
branch
from
3f0a69a
to
b0845f9
Compare
YorkShen
reviewed
Aug 16, 2018
| try { | ||
| if(!versionFile.exists()) | ||
| versionFile.createNewFile(); | ||
| FileWriter fileWriter = new FileWriter(versionFile); |
There was a problem hiding this comment.
Move fileWriter out of the try clause and close the fileWriter in finally would be better.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/WEEX-566
[WEEX-566][Android] add jsb version file to make jsb.so can update
add jsb version file to make jsb.so can update
Bug: WEEX-566