Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Add event listener scroller, add enumerate component method. #1458

Merged
merged 2 commits into from Aug 22, 2018

Conversation

wqyfavor
Copy link
Member

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link

weex-bot commented Aug 21, 2018

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

@cxfeng1-zz cxfeng1-zz merged commit 8b98036 into apache:master Aug 22, 2018
Darin726 pushed a commit to Darin726/incubator-weex that referenced this pull request Sep 12, 2018
* apache/master:
  Add event listener scroller, add enumerate component method. (apache#1458)

# Conflicts:
#	ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
#	ios/sdk/WeexSDK/Sources/Model/WXSDKInstance.h
@wqyfavor wqyfavor deleted the add-event-listener-scroller branch November 23, 2018 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants