This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
0.12 feature support accessibility #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acton393
changed the title
YorkShen
approved these changes
Mar 23, 2017
|
@sospartan Good to merge |
cxfeng1-zz
approved these changes
Mar 27, 2017
| if (0 == [[self.view subviews] count]) { | ||
| self.view.isAccessibilityElement = YES; | ||
| self.view.accessibilityFrame = [[self.view superview] convertRect:self.calculatedFrame toView:nil]; | ||
| } |
There was a problem hiding this comment.
self.view maybe not ready here, please add this logic to [self view], too.
There was a problem hiding this comment.
You do not have to set this property for an accessibility element that represents a subclass of UIView, because such an object’s screen coordinates are already known.
| { | ||
| if (attributes[@"role"]){ | ||
| _role = [WXConvert WXUIAccessibilityTraits:attributes[@"role"]]; | ||
| self.view.accessibilityTraits = _role; |
There was a problem hiding this comment.
self.view maybe not ready here,
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case: http://dotwe.org/weex/5b56a108a7748a56d58d1a715c08d4ab