This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-648][iOS]native batch for dom operations generating from JavaScript #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript wrap a series of dom operations with beginBatch and endBatch directives, when every V-sync signal comes, we try to ensure that the operations between beginBatch and endBatch can be performed in current V-sync, this policy can drop frames maybe, for our policy dropping frames, we only allow 20 frames at most. Bugs:648
Generated by 🚫 dangerJS |
acton393
added a commit
to acton393/incubator-weex
that referenced
this pull request
Oct 18, 2018
…vaScript introduce a native batch for dom operations generating from JavaScript wrap a series of dom operations with beginBatch and endBatch directives, when every V-sync signal comes, we try to ensure that the operations between beginBatch and endBatch can be performed in current V-sync, this policy can drop frames maybe, for our policy dropping frames, we only allow 20 frames at most. see iOS pull request apache#1644 feature:648
…eration queue Bug: 648
acton393
added a commit
to acton393/incubator-weex
that referenced
this pull request
Oct 19, 2018
…vaScript introduce a native batch for dom operations generating from JavaScript wrap a series of dom operations with beginBatch and endBatch directives, when every V-sync signal comes, we try to ensure that the operations between beginBatch and endBatch can be performed in current V-sync, this policy can drop frames maybe, for our policy dropping frames, we only allow 20 frames at most. see iOS pull request apache#1644 feature:648
wqyfavor
reviewed
Oct 29, 2018
| @@ -991,8 +991,38 @@ - (void) _printFlexComponentFrame:(WXComponent *)component | |||
|
|
|||
| - (void)_syncUITasks | |||
| { | |||
| NSArray<dispatch_block_t> *blocks = _uiTaskQueue; | |||
| _uiTaskQueue = [NSMutableArray array]; | |||
| static NSInteger _syncUITaskCount = 0; | |||
There was a problem hiding this comment.
_syncUITaskCount不能声明为static，不同的instance有不同的componentManager不能共用一个变量。
wqyfavor
reviewed
Oct 29, 2018
| blocks = [_uiTaskQueue subarrayWithRange:NSMakeRange(0, mismatchBeginIndex)]; | ||
| [_uiTaskQueue removeObjectsInRange:NSMakeRange(0, blocks.count)]; | ||
| } | ||
|
|
There was a problem hiding this comment.
把下面的dispatch_async也放到if (mismatchBeginIndex > 0)这个if里面吧，空任务的时候减少一次给main提交block。
wqyfavor
reviewed
Oct 29, 2018
|
|
||
| if (mismatchBeginIndex > 0) { | ||
| blocks = [_uiTaskQueue subarrayWithRange:NSMakeRange(0, mismatchBeginIndex)]; | ||
| [_uiTaskQueue removeObjectsInRange:NSMakeRange(0, blocks.count)]; |
There was a problem hiding this comment.
blocks.count换成mismatchBeginIndex吧，看起来更对称一些，而且减少一次blocks.count调用。
wqyfavor
reviewed
Oct 29, 2018
| _syncUITaskCount ++; | ||
| // we only find begin tag but missing end tag, | ||
| if (_syncUITaskCount > (MAX_DROP_FRAME_FOR_BATCH)) { | ||
| // when the wait times come to MAX_DROP_FRAME_FOR_BATCH, we will pop all the stashed operation for user experience. |
There was a problem hiding this comment.
stashed operation -> stashed operations
wqyfavor
reviewed
Oct 29, 2018
| #pragma mark batch mark | ||
|
|
||
| /** | ||
| a start native batch tag for a group of UI operation , company with performBatchEnd |
There was a problem hiding this comment.
去掉多余的空格，operation -> operations
wqyfavor
reviewed
Oct 29, 2018
| - (void)performBatchBegin; | ||
|
|
||
| /** | ||
| an end native batch tag for a group of UI operation, company with performBatchBegin |
wqyfavor
reviewed
Oct 29, 2018
| } | ||
| } | ||
|
|
||
| NSArray<dispatch_block_t> *blocks = nil; |
There was a problem hiding this comment.
blocks声明放到下面if (mismatchBeginIndex > 0)里吧
|
👍 @wqyfavor thanks for your suggestions，I have updated my pull request. |
wqyfavor
approved these changes
Oct 31, 2018
| NSArray<dispatch_block_t> *blocks = nil; | ||
| blocks = [_uiTaskQueue subarrayWithRange:NSMakeRange(0, mismatchBeginIndex)]; | ||
| [_uiTaskQueue removeObjectsInRange:NSMakeRange(0, mismatchBeginIndex)]; | ||
| dispatch_async(dispatch_get_main_queue(), ^{ |
There was a problem hiding this comment.
加上if ([blocks count] == 0) return;吧
YorkShen
pushed a commit
that referenced
this pull request
Nov 5, 2018
…vaScript (#1647) * [WEEX-648][Android]native batch for dom operations generating from JavaScript introduce a native batch for dom operations generating from JavaScript wrap a series of dom operations with beginBatch and endBatch directives, when every V-sync signal comes, we try to ensure that the operations between beginBatch and endBatch can be performed in current V-sync, this policy can drop frames maybe, for our policy dropping frames, we only allow 20 frames at most. see iOS pull request #1644
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce a native batch for dom operations generating from JavaScript
wrap a series of dom operations with beginBatch and endBatch directives, when every V-sync signal comes, we try to ensure that the operations between beginBatch and endBatch can be performed in current V-sync, this policy can drop frames maybe, for our policy dropping frames, we only allow 20 frames at most.
see Android policy pull request #1647
feature:648