This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-669][android] fix slider crash when adapter is null #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
YorkShen
reviewed
Nov 26, 2018
android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
Outdated
Show resolved
Hide resolved
YorkShen
approved these changes
Nov 26, 2018
android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
Outdated
Show resolved
Hide resolved
win80540
force-pushed
the
feature/RTL
branch
from
77905d7
to
e8bad6a
Compare
win80540
force-pushed
the
feature/RTL
branch
from
e8bad6a
to
0a86d4f
Compare
YorkShen
approved these changes
Nov 26, 2018
android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix slider crash when adapter is null
java.lang.NullPointerException: Attempt to invoke virtual method 'void com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' on a null object reference
at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217)
at com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44)
at com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6195)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)