Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

* [Android] edit interaction logic && edit exception report logic #1835

Merged

Conversation

lucky-chen
Copy link
Contributor

  • determine if the element is on the screen (element edge)
  • if component has "ignoreInteraction" attrs,componentTree will not calculate
  • report pageName (not url)
  • every instance report one overlay exception at most

- determine if the element is on the screen (element edge)
- if component has "ignoreInteraction" attrs,componentTree will not calculate
- report pageName  (not url)
- every instance report one overlay exception at most
@weex-bot
Copy link

weex-bot commented Nov 28, 2018

Fails
🚫 Failed to run assembleDebug task for android.
Messages
📖 android build verification finished.

Generated by 🚫 dangerJS

Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen YorkShen merged commit 5eb62df into apache:master Nov 28, 2018
katherine95s pushed a commit to katherine95s/incubator-weex that referenced this pull request Jul 4, 2019
…ache#1835)

- determine if the element is on the screen (element edge)
- if component has "ignoreInteraction" attrs,componentTree will not calculate
- report pageName  (not url)
- every instance report one overlay exception at most
katherine95s pushed a commit to katherine95s/incubator-weex that referenced this pull request Jul 11, 2019
…ache#1835)

- determine if the element is on the screen (element edge)
- if component has "ignoreInteraction" attrs,componentTree will not calculate
- report pageName  (not url)
- every instance report one overlay exception at most
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants