This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[Android] fix playground app crash while url query is null #1847
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
YorkShen
suggested changes
Nov 29, 2018
| @@ -275,7 +275,7 @@ private void startHotRefresh() { | |||
| URL url = new URL(mUri.toString()); | |||
| String host = url.getHost(); | |||
| String query = url.getQuery(); | |||
| String wsport = getUrlParam("wsport", query); | |||
| String wsport = query == null? "8082" : getUrlParam("wsport", query); | |||
There was a problem hiding this comment.
TextUtils.isEmpty(query)? "8082" : getUrlParam("wsport", query)
erha19
force-pushed
the
weex-playground-app
branch
from
382ffd4
to
10a3975
Compare
|
@YorkShen done! |
katherine95s
pushed a commit
to katherine95s/incubator-weex
that referenced
this pull request
Jul 4, 2019
* [Android] replace IWXDebugProxy as WXSDKInstance class
katherine95s
pushed a commit
to katherine95s/incubator-weex
that referenced
this pull request
Jul 11, 2019
* [Android] replace IWXDebugProxy as WXSDKInstance class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed:
Fixed #1842.