Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[iOS] Protect dom.getComponentRect argument for there are so many mis… #2093

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

wqyfavor
Copy link
Member

…uses by front-end developers.

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

Copy link
Member

@doumafang doumafang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@weex-bot
Copy link

weex-bot commented Jan 29, 2019

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

@doumafang doumafang merged commit 1c79ada into apache:master Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants