Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[iOS] On iOS "status_bar_height" is not need, remove it to make threa… #2108

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

wqyfavor
Copy link
Member

…d checker happy.

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link

weex-bot commented Feb 11, 2019

Fails
🚫 Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header.
Warnings
⚠️ No Changelog changes!
Messages
📖 danger test finished.

Generated by 🚫 dangerJS

Copy link
Contributor

@jianhan-he jianhan-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@doumafang doumafang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@doumafang doumafang merged commit 979d562 into apache:master Feb 12, 2019
@wqyfavor wqyfavor deleted the fix-mainthread branch February 12, 2019 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants