Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[jsfm] Throw the caught exception in componentHook #2285

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

Hanks10100
Copy link
Contributor

Brief Description of the PR

Still throw the caught exception in the "componentHook" anyway, it should be processed by the native for consistent error collecting.

Still throw the caught exception in the "componentHook" anyway, it should
be processed by the native for consistent error collecting.
@Hanks10100 Hanks10100 requested a review from YorkShen April 8, 2019 08:56
@weex-bot
Copy link

weex-bot commented Apr 8, 2019

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen YorkShen merged commit c062c8f into apache:master Apr 10, 2019
Hanks10100 added a commit to Hanks10100/incubator-weex that referenced this pull request Apr 10, 2019
Notable changes:

* Throw the caught exception in componentHook (apache#2285)
YorkShen pushed a commit that referenced this pull request Apr 10, 2019
Notable changes:

* Throw the caught exception in componentHook (#2285)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants