Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

replace Java WxTimerModule with C++ setTimeout/setInterval implementa… #232

Merged
merged 2 commits into from
Apr 13, 2017
Merged

Conversation

lycool
Copy link

@lycool lycool commented Apr 7, 2017

replace Java WxTimerModule with C++ setTimeout/setInterval implementation.

clear all unhandled setTimeout/setInterval timers after Weex instance is destroyed

@@ -570,7 +570,10 @@ public int callNative(String instanceId, String tasks, String callback) {
if (WXEnvironment.isApkDebugable()) {
mLodBuilder.append("[WXBridgeManager] callNative >>>> instanceId:").append(instanceId)
.append(", tasks:").append(tasks).append(", callback:").append(callback);
WXLogUtils.d(mLodBuilder.substring(0));

//WXLogUtils.d(mLodBuilder.substring(0));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WXLogUtils.d removed

@@ -1069,7 +1072,10 @@ public void invokeExecJS(String instanceId, String namespace, String function,
.append("function:").append(function);
if(logTaskDetail)
mLodBuilder.append(" tasks:").append(WXJsonUtils.fromObjectToJSONString(args));
WXLogUtils.d(mLodBuilder.substring(0));

//WXLogUtils.d(mLodBuilder.substring(0));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WXLogUtils.d removed

@asfgit asfgit merged commit 043e632 into apache:0.12-dev Apr 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants