Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android] Remove duplicate receiver in manifest and remove class definition #2879

Merged
merged 1 commit into from Sep 4, 2019

Conversation

YorkShen
Copy link
Contributor

@YorkShen YorkShen commented Sep 4, 2019

Remove duplicate receiver in manifest and remove class definition

  • globalEvent demo, work as before.
  • globalEvent Documentation
  • As there is no intent-filter for the receiver in the manifest, the receiver in the manifest is useless. Actually, the receiver is registered in code with an intent.

@weex-bot
Copy link

weex-bot commented Sep 4, 2019

Warnings
⚠️ Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/module/WXDomModule.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
⚠️ Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/common/WXWorkThreadManager.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
⚠️ No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md
⚠️ Current pr not bind the milestone
Messages
📖 danger test finished.

Generated by 🚫 dangerJS against 78cc9b8

Copy link
Contributor

@lucky-chen lucky-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@lucky-chen lucky-chen merged commit cbfb57b into apache:master Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants