This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[android] js exception adapter change to list. so that can handler m… #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re than one listener. Now faced a problem is WeexErrorCallback (used by Motu weex js exception caught) is conflict with JSExceptionGlobalEventReport (added in taobao_weex_adapter to caught js exception and throw it to js, we use JSTracker to log exceptions.)
Danger has erroredError: TypeError TypeError: diff.match is not a function
at Object.<anonymous> (dangerfile.js:109:24)
at Runtime._execModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:447:13)
at Runtime.requireModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:295:14)
at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:136:33
at ensureCleanDangerfile (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:176:5)
at Object.<anonymous> (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:135:21)
at step (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:32:23)
at Object.next (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:13:53)
at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:7:71
at __awaiter (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:3:12)Generated by 🚫 dangerJS |
|
do it in WeexErrorCallBack at crashreportadapterLoader |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[android] js exception adapter change to list. so that can handler more than one listener.
Now faced a problem is
WeexErrorCallback (used by Motu weex js exception caught)
is conflict with
JSExceptionGlobalEventReport (added in taobao_weex_adapter to caught js exception and throw it to js, we use JSTracker to log exceptions.)