This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[android] list support drag-drop feature #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
sospartan
reviewed
Jun 5, 2017
|
|
||
| private static final String EVENT_START_DRAG = "dragstart"; | ||
| private static final String EVENT_END_DRAG = "dragend"; | ||
|
|
There was a problem hiding this comment.
Remove these unnecessary lines.
sospartan
suggested changes
Jun 5, 2017
|
|
||
| class DefaultDragHelper implements WXDragHelper { | ||
|
|
||
| private boolean isLongPressEnabled; |
| @Override | ||
| public int getMovementFlags(RecyclerView recyclerView, RecyclerView.ViewHolder viewHolder) { | ||
| if(recyclerView.getLayoutManager() instanceof GridLayoutManager || recyclerView.getLayoutManager() instanceof StaggeredGridLayoutManager){ | ||
| final int dragFlags = ItemTouchHelper.UP | ItemTouchHelper.DOWN | ItemTouchHelper.LEFT | ItemTouchHelper.RIGHT; |
There was a problem hiding this comment.
Just pass the expression to the method, the final variable dragFlags is useless.
| private final WXDragHelper mWXDragHelper; | ||
| private boolean enableDifferentViewTypeDrag = false; | ||
|
|
||
| private int dragFrom = -1; |
| return triggerType; | ||
| } | ||
|
|
||
| private boolean getExcluded(@Nullable ImmutableDomObject domObject) { |
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
License header is incorrect.
| * Date: 16/4/5<br/> | ||
| * Time: 上午11:34<br/> | ||
| */ | ||
| interface WXDragHelper { |
There was a problem hiding this comment.
Do not suffix WX with new file.
|
Please put the PR description to JIRA. And rebase your branch to fix the travis issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature:
extend attrs:
list:
cell:
any component:
JIRA: https://issues.apache.org/jira/browse/WEEX-37