New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] list support drag-drop feature #416

Merged
merged 12 commits into from Jun 9, 2017

Conversation

Projects
None yet
4 participants
@Rowandjj
Contributor

Rowandjj commented Jun 5, 2017

use RecyclerView's ItemTouchHelper to implement drag-drop feature.

feature:

  1. support both pan and longPress gesture to trigger drag-drop;
  2. support liner/grid layout;
  3. support dragStart/dragEnd event;
  4. support excluded some cells when dragging;

extend attrs:

list:
  • draggable: whether draggable or not;
  • drag-trigger-type: which gesture type will trigger drag-drop;
cell:
  • drag-excluded: whether we should ignore current cell for dragging;
any component:
  • drag-anchor: the anchor that will trigger drag-drop

JIRA: https://issues.apache.org/jira/browse/WEEX-37

@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Jun 5, 2017

Warnings
⚠️ No Changelog changes!
⚠️ This PR should update related documents as well.
⚠️ Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
Messages
📖 According to the blame info, we recommended @sospartan , @misakuo to be the reviewers.

Generated by 🚫 dangerJS

weex-bot commented Jun 5, 2017

Warnings
⚠️ No Changelog changes!
⚠️ This PR should update related documents as well.
⚠️ Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
Messages
📖 According to the blame info, we recommended @sospartan , @misakuo to be the reviewers.

Generated by 🚫 dangerJS

@sospartan

This comment has been minimized.

Show comment
Hide comment
@sospartan

sospartan Jun 7, 2017

Contributor

Please put the PR description to JIRA. And rebase your branch to fix the travis issue.

Contributor

sospartan commented Jun 7, 2017

Please put the PR description to JIRA. And rebase your branch to fix the travis issue.

@Rowandjj

This comment has been minimized.

Show comment
Hide comment
Contributor

Rowandjj commented Jun 8, 2017

@Rowandjj Rowandjj closed this Jun 8, 2017

@Rowandjj Rowandjj reopened this Jun 8, 2017

@Rowandjj Rowandjj closed this Jun 8, 2017

@Rowandjj Rowandjj reopened this Jun 8, 2017

@asfgit asfgit merged commit 45cb5f0 into apache:0.14-dev Jun 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment