Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

* [android] Support rotateX and rotateY, optimize animation as well. #418

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

YorkShen
Copy link
Contributor

@YorkShen YorkShen commented Jun 5, 2017

Ref corresponding JIRA issue.

@weex-bot
Copy link

weex-bot commented Jun 5, 2017

Warnings
⚠️ No Changelog changes!
⚠️ This PR modify SDK code without add/modify testcases.
⚠️ This PR should update related documents as well.
Messages
📖 According to the blame info, we recommended @zshshr , @luics to be the reviewers.

Generated by 🚫 dangerJS

@YorkShen YorkShen force-pushed the android-feature-animation branch 6 times, most recently from 126b199 to 98d8023 Compare June 7, 2017 02:39
@sospartan
Copy link
Contributor

Pls create JIRA issue before you merge this.

@@ -676,6 +674,9 @@ protected boolean setProperty(String key, Object param) {
boolean isHidden = WXUtils.getBoolean(param,false);
setAriaHidden(isHidden);
return true;
// case Constants.Name.PERSPECTIVE:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these lins.

@@ -0,0 +1,17 @@
package com.taobao.weex.ui.animation;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src header

@@ -0,0 +1,46 @@
package com.taobao.weex.ui.animation;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src header.

@@ -174,6 +174,7 @@
String NORMAL = "normal";
String ARIA_LABEL = "ariaLabel";
String ARIA_HIDDEN = "ariaHidden";
//String PERSPECTIVE = "perspective";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented line.

@@ -0,0 +1,17 @@
package com.taobao.weex.ui.animation;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src header.

@sospartan
Copy link
Contributor

@YorkShen YorkShen force-pushed the android-feature-animation branch 3 times, most recently from cda4f05 to 634726d Compare June 8, 2017 09:01
@notdanger

* [Use LayoutParamsProperty instead of DimensionUpdateListener to achieve height/width animation.](http://dotwe.org/vue/c7a70462a136b61e11ab37f384862003)
* [Support rotateX and rotateY.](http://dotwe.org/vue/e712dd2ad4df470bab940d8e0e6d052d).
* Stop remove transform and transform-origin from WXStyle in UpdateStyleAction.
* Stop execute animation callback if corresponding WXInstance is destroyed when animation finished.

Corresponding [JIRA issue](https://issues.apache.org/jira/browse/WEEX-38).
@asfgit asfgit merged commit cd91163 into apache:0.14-dev Jun 8, 2017
@YorkShen YorkShen deleted the android-feature-animation branch June 8, 2017 09:44
@YorkShen YorkShen restored the android-feature-animation branch July 21, 2017 07:38
@YorkShen YorkShen deleted the android-feature-animation branch July 21, 2017 07:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants