New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* [android] Support rotateX and rotateY, optimize animation as well. #418

Merged
merged 1 commit into from Jun 8, 2017

Conversation

Projects
None yet
4 participants
@YorkShen
Contributor

YorkShen commented Jun 5, 2017

Ref corresponding JIRA issue.

@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Jun 5, 2017

Warnings
⚠️ No Changelog changes!
⚠️ This PR modify SDK code without add/modify testcases.
⚠️ This PR should update related documents as well.
Messages
📖 According to the blame info, we recommended @zshshr , @luics to be the reviewers.

Generated by 🚫 dangerJS

weex-bot commented Jun 5, 2017

Warnings
⚠️ No Changelog changes!
⚠️ This PR modify SDK code without add/modify testcases.
⚠️ This PR should update related documents as well.
Messages
📖 According to the blame info, we recommended @zshshr , @luics to be the reviewers.

Generated by 🚫 dangerJS

@sospartan

This comment has been minimized.

Show comment
Hide comment
@sospartan

sospartan Jun 7, 2017

Contributor

Pls create JIRA issue before you merge this.

Contributor

sospartan commented Jun 7, 2017

Pls create JIRA issue before you merge this.

Show outdated Hide outdated android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java
@@ -0,0 +1,17 @@
package com.taobao.weex.ui.animation;

This comment has been minimized.

@sospartan

sospartan Jun 8, 2017

Contributor

src header

@sospartan

sospartan Jun 8, 2017

Contributor

src header

@@ -0,0 +1,46 @@
package com.taobao.weex.ui.animation;

This comment has been minimized.

@sospartan

sospartan Jun 8, 2017

Contributor

src header.

@sospartan

sospartan Jun 8, 2017

Contributor

src header.

Show outdated Hide outdated android/sdk/src/main/java/com/taobao/weex/common/Constants.java
@@ -0,0 +1,17 @@
package com.taobao.weex.ui.animation;

This comment has been minimized.

@sospartan

sospartan Jun 8, 2017

Contributor

src header.

@sospartan

sospartan Jun 8, 2017

Contributor

src header.

@sospartan

This comment has been minimized.

Show comment
Hide comment
Contributor

sospartan commented Jun 8, 2017

* [Android] Support rotateX and rotateY, optimize animation as well.
@notdanger

* [Use LayoutParamsProperty instead of DimensionUpdateListener to achieve height/width animation.](http://dotwe.org/vue/c7a70462a136b61e11ab37f384862003)
* [Support rotateX and rotateY.](http://dotwe.org/vue/e712dd2ad4df470bab940d8e0e6d052d).
* Stop remove transform and transform-origin from WXStyle in UpdateStyleAction.
* Stop execute animation callback if corresponding WXInstance is destroyed when animation finished.

Corresponding [JIRA issue](https://issues.apache.org/jira/browse/WEEX-38).

@asfgit asfgit merged commit cd91163 into apache:0.14-dev Jun 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@YorkShen YorkShen deleted the YorkShen:android-feature-animation branch Jun 8, 2017

@YorkShen YorkShen restored the YorkShen:android-feature-animation branch Jul 21, 2017

@YorkShen YorkShen deleted the YorkShen:android-feature-animation branch Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment