This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
* [android] Fixing clearTimeout and clearInterval doesn't work when funId is greater than 127 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
sospartan
suggested changes
Jun 12, 2017
| public class WXTimerModule extends WXModule implements Destroyable, Handler.Callback { | ||
|
|
||
| private final static String TAG = "timer"; | ||
| private Handler handler; | ||
| private SparseArray<Integer> antiIntAutoBoxing; |
There was a problem hiding this comment.
antiIntAutoBoxing is enough.
- JIRA is down, BTW.
- JIRA waring is irrelevant. I'm just fixing bug.
Due the implementation of [int auto-boxing](https://stackoverflow.com/questions/3130311/weird-integer-boxing-in-java) and [messageQueue](https://stackoverflow.com/questions/36190851/android-os-handler-removemessages-doesnt-work-when-poxing-value-type-as-msg-obj), clearTimeout and clearTimeout won't work when funId is greater than 127. It works fine when funId is smaller than 127. Ref this [demo](http://dotwe.org/vue/1c7b541231eb86db98afe3c1b48bcdcc)
YorkShen
force-pushed
the
android-bugfix-timer
branch
from
0040dca
to
fefe2e8
Compare
|
YorkShen
changed the title
sospartan
approved these changes
Jun 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due the implementation of int auto-boxing and messageQueue, clearTimeout and clearTimeout won't work when funId is greater than 127. It works fine when funId is smaller than 127.