New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* [android] Fixing clearTimeout and clearInterval doesn't work when funId is greater than 127 #439

Merged
merged 1 commit into from Jun 13, 2017

Conversation

Projects
None yet
4 participants
@YorkShen
Contributor

YorkShen commented Jun 12, 2017

Due the implementation of int auto-boxing and messageQueue, clearTimeout and clearTimeout won't work when funId is greater than 127. It works fine when funId is smaller than 127.

@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Jun 12, 2017

Warnings
⚠️ No Changelog changes!
⚠️ This PR should update related documents as well.
Messages
📖 According to the blame info, we recommended @Rowandjj , @sospartan to be the reviewers.

Generated by 🚫 dangerJS

weex-bot commented Jun 12, 2017

Warnings
⚠️ No Changelog changes!
⚠️ This PR should update related documents as well.
Messages
📖 According to the blame info, we recommended @Rowandjj , @sospartan to be the reviewers.

Generated by 🚫 dangerJS

@sospartan

Some problems need fix:

  • A JIRA issue relate to this PR
  • The danger warn and error
@YorkShen

This comment has been minimized.

Show comment
Hide comment
@YorkShen

YorkShen Jun 12, 2017

Contributor
  • JIRA is down, BTW.
  • JIRA waring is irrelevant. I'm just fixing bug. NO document is needed.
Contributor

YorkShen commented Jun 12, 2017

  • JIRA is down, BTW.
  • JIRA waring is irrelevant. I'm just fixing bug. NO document is needed.

@YorkShen YorkShen changed the title from * [android] Fixing clearTimeout and clearInterval doesn't when funId is greater than 127 to * [android] Fixing clearTimeout and clearInterval doesn't work when funId is greater than 127 Jun 13, 2017

@YorkShen

This comment has been minimized.

Show comment
Hide comment

@asfgit asfgit merged commit fefe2e8 into apache:0.14-dev Jun 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@YorkShen YorkShen deleted the YorkShen:android-bugfix-timer branch Jun 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment