Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

* [android] fix : list OOM cause by viewHolder cache，set the upper limit for the viewHolder cache pool #512

Merged
merged 2 commits into from
Jul 21, 2017
Merged

* [android] fix : list OOM cause by viewHolder cache，set the upper limit for the viewHolder cache pool #512

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0f99ea
* [android] fix : set the upper limit for the viewHolder cache pool
miomin Jul 17, 2017
4ba3101
* [android] fix waterfall crash
Jul 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,16 +317,9 @@ protected T initComponentHostView(@NonNull Context context) {
public void onScrollStateChanged(RecyclerView recyclerView, int newState) {
super.onScrollStateChanged(recyclerView, newState);

if (newState == RecyclerView.SCROLL_STATE_IDLE) {
for (ListBaseViewHolder holder : recycleViewList) {
if (holder != null
&& holder.getComponent() != null
&& !holder.getComponent().isUsing()) {
holder.recycled();
}
}
recycleViewList.clear();
}
if (newState == RecyclerView.SCROLL_STATE_IDLE)
recycleViewHolderList();

List<OnWXScrollListener> listeners = getInstance().getWXScrollListeners();
if (listeners != null && listeners.size() > 0) {
for (OnWXScrollListener listener : listeners) {
Expand Down Expand Up @@ -382,6 +375,17 @@ public void onGlobalLayout() {
return bounceRecyclerView;
}

private void recycleViewHolderList() {
for (ListBaseViewHolder holder : recycleViewList) {
if (holder != null
&& holder.getComponent() != null
&& !holder.getComponent().isUsing()) {
holder.recycled();
}
}
recycleViewList.clear();
}

@Override
public void bindStickStyle(WXComponent component) {
stickyHelper.bindStickStyle(component, mStickyMap);
Expand Down Expand Up @@ -833,6 +837,12 @@ public void onViewRecycled(ListBaseViewHolder holder) {
holder.setComponentUsing(false);
if(holder.canRecycled()) {
recycleViewList.add(holder);

/**
* Recycle cache{@link recycleViewList} when recycleViewList.size() > list max child count
*/
if (recycleViewList.size() > getChildCount() + 1)
recycleViewHolderList();
} else {
WXLogUtils.w(TAG, "this holder can not be allowed to recycled" );
}
Expand Down