New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html5] extract render core and plugins from full verison. #533

Merged
merged 41 commits into from Jul 28, 2017

Conversation

Projects
None yet
3 participants
@MrRaindrop
Contributor

MrRaindrop commented Jul 26, 2017

This pr separate vue-render into two parts: render core and plugins.

The render core includes all the basic function for render to work, and the basic components which are text, image, div and the scrollable components and their child components such as cell, header for list and scroller.

The plugins part is the extended built-in components and API modules. Components like a and video are not always used in user's project, therefore it's a big waste for bandwidth and bundle size to integrate these components into render core part. For this sake I package the components into npm packages, and now users can import the corresponding npm package into their project if they use a plugin component.

And I also change some packing logic in build config files, so that you can pack up all the plugins and the render core by just using a certain npm script.

I also adjust some test files since the file structure of components and modules have been changed into installable modules.

MrRaindrop added some commits Jun 29, 2017

* [html5] implementate the integrated components as render's plugin, …
…which should have no directly dependency on render core.

@MrRaindrop MrRaindrop closed this Jul 27, 2017

@MrRaindrop MrRaindrop reopened this Jul 27, 2017

@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Jul 28, 2017

Fails
🚫 Running your Dangerfile has Failed

Danger has errored

Error: SyntaxError

�[0m �[90m 294 | �[39m    }
 �[90m 295 | �[39m    parseDeleteAndNormalLines(result�[33m.�[39mdata�[33m,�[39m fileToDeletedLinesMap�[33m,�[39m fileToNormalLinesMap)
�[31m�[1m>�[22m�[39m�[90m 296 | �[39m    �[36mvar�[39m promises �[33m=�[39m danger�[33m.�[39mgit�[33m.�[39mmodifiedgit _files�[33m.�[39mmap(�[36mfunction�[39m(file) {
 �[90m     | �[39m                                          �[31m�[1m^�[22m�[39m
 �[90m 297 | �[39m      let repoURL �[33m=�[39m danger�[33m.�[39mgithub�[33m.�[39mpr�[33m.�[39mbase�[33m.�[39mrepo�[33m.�[39mhtml_url
 �[90m 298 | �[39m      let fileName �[33m=�[39m file�[33m.�[39mreplace(�[35m/^.*[\\\/]/�[39m�[33m,�[39m �[32m''�[39m)
 �[90m 299 | �[39m      let blameURL �[33m=�[39m repoURL �[33m+�[39m �[32m'/blame/'�[39m �[33m+�[39m danger�[33m.�[39mgithub�[33m.�[39mpr�[33m.�[39mbase�[33m.�[39mref �[33m+�[39m �[32m'/'�[39m �[33m+�[39m file�[0m

Generated by 🚫 dangerJS

weex-bot commented Jul 28, 2017

Fails
🚫 Running your Dangerfile has Failed

Danger has errored

Error: SyntaxError

�[0m �[90m 294 | �[39m    }
 �[90m 295 | �[39m    parseDeleteAndNormalLines(result�[33m.�[39mdata�[33m,�[39m fileToDeletedLinesMap�[33m,�[39m fileToNormalLinesMap)
�[31m�[1m>�[22m�[39m�[90m 296 | �[39m    �[36mvar�[39m promises �[33m=�[39m danger�[33m.�[39mgit�[33m.�[39mmodifiedgit _files�[33m.�[39mmap(�[36mfunction�[39m(file) {
 �[90m     | �[39m                                          �[31m�[1m^�[22m�[39m
 �[90m 297 | �[39m      let repoURL �[33m=�[39m danger�[33m.�[39mgithub�[33m.�[39mpr�[33m.�[39mbase�[33m.�[39mrepo�[33m.�[39mhtml_url
 �[90m 298 | �[39m      let fileName �[33m=�[39m file�[33m.�[39mreplace(�[35m/^.*[\\\/]/�[39m�[33m,�[39m �[32m''�[39m)
 �[90m 299 | �[39m      let blameURL �[33m=�[39m repoURL �[33m+�[39m �[32m'/blame/'�[39m �[33m+�[39m danger�[33m.�[39mgithub�[33m.�[39mpr�[33m.�[39mbase�[33m.�[39mref �[33m+�[39m �[32m'/'�[39m �[33m+�[39m file�[0m

Generated by 🚫 dangerJS

@asfgit asfgit merged commit c45b53c into apache:0.16-dev Jul 28, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment