This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[html5] extract render core and plugins from full verison. #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which should have no directly dependency on render core.
…s into npm packages
Danger has erroredError: SyntaxError �[0m �[90m 294 | �[39m }
�[90m 295 | �[39m parseDeleteAndNormalLines(result�[33m.�[39mdata�[33m,�[39m fileToDeletedLinesMap�[33m,�[39m fileToNormalLinesMap)
�[31m�[1m>�[22m�[39m�[90m 296 | �[39m �[36mvar�[39m promises �[33m=�[39m danger�[33m.�[39mgit�[33m.�[39mmodifiedgit _files�[33m.�[39mmap(�[36mfunction�[39m(file) {
�[90m | �[39m �[31m�[1m^�[22m�[39m
�[90m 297 | �[39m let repoURL �[33m=�[39m danger�[33m.�[39mgithub�[33m.�[39mpr�[33m.�[39mbase�[33m.�[39mrepo�[33m.�[39mhtml_url
�[90m 298 | �[39m let fileName �[33m=�[39m file�[33m.�[39mreplace(�[35m/^.*[\\\/]/�[39m�[33m,�[39m �[32m''�[39m)
�[90m 299 | �[39m let blameURL �[33m=�[39m repoURL �[33m+�[39m �[32m'/blame/'�[39m �[33m+�[39m danger�[33m.�[39mgithub�[33m.�[39mpr�[33m.�[39mbase�[33m.�[39mref �[33m+�[39m �[32m'/'�[39m �[33m+�[39m file�[0m Generated by 🚫 dangerJS |
This was referenced Jun 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr separate vue-render into two parts: render core and plugins.
The render core includes all the basic function for render to work, and the basic components which are
text
,image
,div
and the scrollable components and their child components such ascell
,header
forlist
andscroller
.The plugins part is the extended built-in components and API modules. Components like
a
andvideo
are not always used in user's project, therefore it's a big waste for bandwidth and bundle size to integrate these components into render core part. For this sake I package the components into npm packages, and now users can import the corresponding npm package into their project if they use a plugin component.And I also change some packing logic in build config files, so that you can pack up all the plugins and the render core by just using a certain npm script.
I also adjust some test files since the file structure of components and modules have been changed into installable modules.