New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* [android] The timer in Android will supports float interval/delay #699

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
4 participants
@YorkShen
Contributor

YorkShen commented Sep 14, 2017

The timer in Android will supports float interval/delay and transform them to int.

As some coders always ignore the docs and pass float value, which is not supported, the sdk has no way but to be tolerant with wrong behavior.

Refer https://issues.apache.org/jira/browse/WEEX-68

* [android]The timer in Android will supports float interval/delay an…
…d transform them to int.

As some codes always ignore the docs and pass float value, which is not supported, the sdk has no way but to be tolerant with wrong behavior.
@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Sep 14, 2017

Warnings
⚠️ No Changelog changes!
⚠️ This PR should update related documents as well.
⚠️ Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/module/WXTimerModule.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
Messages
📖 According to the blame info, we recommended @sospartan , @Rowandjj to be the reviewers.

Generated by 🚫 dangerJS

weex-bot commented Sep 14, 2017

Warnings
⚠️ No Changelog changes!
⚠️ This PR should update related documents as well.
⚠️ Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/module/WXTimerModule.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
Messages
📖 According to the blame info, we recommended @sospartan , @Rowandjj to be the reviewers.

Generated by 🚫 dangerJS

@zshshr

zshshr approved these changes Sep 14, 2017

@asfgit asfgit merged commit c003509 into apache:0.16-dev Sep 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@YorkShen YorkShen deleted the YorkShen:android-timer branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment