Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

* [android] fix flicker caused by coexistence of box-shadow and borde… #780

Merged
merged 3 commits into from
Oct 18, 2017

Conversation

misakuo
Copy link
Member

@misakuo misakuo commented Oct 10, 2017

@weex-bot
Copy link

weex-bot commented Oct 10, 2017

Messages
📖 android test finished.

Generated by 🚫 dangerJS

@gurisxie
Copy link
Contributor

@misakuo android unittest error,please have a look!

com.taobao.weex.ui.component.WXSwitchTest > testAddEvent FAILED
java.lang.NullPointerException
at com.taobao.weex.ui.component.WXComponent.clearBoxShadow(WXComponent.java:915)
at com.taobao.weex.ui.component.WXComponent.setComponentLayoutParams(WXComponent.java:513)
at com.taobao.weex.ui.component.WXComponent.setLayout(WXComponent.java:495)
at com.taobao.weex.ui.component.ComponentTest.create(ComponentTest.java:55)
at com.taobao.weex.ui.component.WXSwitchTest.setUp(WXSwitchTest.java:58)

com.taobao.weex.ui.component.WXSwitchTest > testSetProperty FAILED
java.lang.NullPointerException
at com.taobao.weex.ui.component.WXComponent.clearBoxShadow(WXComponent.java:915)
at com.taobao.weex.ui.component.WXComponent.setComponentLayoutParams(WXComponent.java:513)
at com.taobao.weex.ui.component.WXComponent.setLayout(WXComponent.java:495)
at com.taobao.weex.ui.component.ComponentTest.create(ComponentTest.java:55)
at com.taobao.weex.ui.component.WXSwitchTest.setUp(WXSwitchTest.java:58)

Copy link
Member

@gubaojian gubaojian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

box shadow very good soluation

@asfgit asfgit merged commit 61ead2a into apache:release-0.16 Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants