New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* [android] fix flicker caused by coexistence of box-shadow and borde… #780

Merged
merged 3 commits into from Oct 18, 2017

Conversation

Projects
None yet
5 participants
@misakuo
Contributor

misakuo commented Oct 10, 2017

@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Oct 10, 2017

Messages
📖 android test finished.

Generated by 🚫 dangerJS

weex-bot commented Oct 10, 2017

Messages
📖 android test finished.

Generated by 🚫 dangerJS

@gurisxie

This comment has been minimized.

Show comment
Hide comment
@gurisxie

gurisxie Oct 11, 2017

Contributor

@misakuo android unittest error,please have a look!

com.taobao.weex.ui.component.WXSwitchTest > testAddEvent FAILED
java.lang.NullPointerException
at com.taobao.weex.ui.component.WXComponent.clearBoxShadow(WXComponent.java:915)
at com.taobao.weex.ui.component.WXComponent.setComponentLayoutParams(WXComponent.java:513)
at com.taobao.weex.ui.component.WXComponent.setLayout(WXComponent.java:495)
at com.taobao.weex.ui.component.ComponentTest.create(ComponentTest.java:55)
at com.taobao.weex.ui.component.WXSwitchTest.setUp(WXSwitchTest.java:58)

com.taobao.weex.ui.component.WXSwitchTest > testSetProperty FAILED
java.lang.NullPointerException
at com.taobao.weex.ui.component.WXComponent.clearBoxShadow(WXComponent.java:915)
at com.taobao.weex.ui.component.WXComponent.setComponentLayoutParams(WXComponent.java:513)
at com.taobao.weex.ui.component.WXComponent.setLayout(WXComponent.java:495)
at com.taobao.weex.ui.component.ComponentTest.create(ComponentTest.java:55)
at com.taobao.weex.ui.component.WXSwitchTest.setUp(WXSwitchTest.java:58)

Contributor

gurisxie commented Oct 11, 2017

@misakuo android unittest error,please have a look!

com.taobao.weex.ui.component.WXSwitchTest > testAddEvent FAILED
java.lang.NullPointerException
at com.taobao.weex.ui.component.WXComponent.clearBoxShadow(WXComponent.java:915)
at com.taobao.weex.ui.component.WXComponent.setComponentLayoutParams(WXComponent.java:513)
at com.taobao.weex.ui.component.WXComponent.setLayout(WXComponent.java:495)
at com.taobao.weex.ui.component.ComponentTest.create(ComponentTest.java:55)
at com.taobao.weex.ui.component.WXSwitchTest.setUp(WXSwitchTest.java:58)

com.taobao.weex.ui.component.WXSwitchTest > testSetProperty FAILED
java.lang.NullPointerException
at com.taobao.weex.ui.component.WXComponent.clearBoxShadow(WXComponent.java:915)
at com.taobao.weex.ui.component.WXComponent.setComponentLayoutParams(WXComponent.java:513)
at com.taobao.weex.ui.component.WXComponent.setLayout(WXComponent.java:495)
at com.taobao.weex.ui.component.ComponentTest.create(ComponentTest.java:55)
at com.taobao.weex.ui.component.WXSwitchTest.setUp(WXSwitchTest.java:58)

@gubaojian

box shadow very good soluation

@asfgit asfgit merged commit 61ead2a into apache:release-0.16 Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment