This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-94][iOS] fix iOS 8 scrollview assign delegate crash #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As iOS developers all knowns, assign property will not be set nil when its object deallocated, and weak object will does, so we must set it to the nil value, in case of crash about messaging to zombie object. In iOS 8 and the older iOS, the property of delegate of UIScrollView is assign, so we must set it to nil manually when object deallocated. And in iOS 9 and later iOS, apple change the delegate property of UIScrollView it to weak, so we don't set it to nil value any more. For compatibility on iOS 8, here we must set it to nil value. Bug: 94
Generated by 🚫 dangerJS |
cxfeng1-zz
approved these changes
Nov 8, 2017
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As iOS developers all knowns, assign property will not be set nil when
its object deallocated, and weak object will does, so we must set it to the
nil value, in case of crash about messaging to zombie object. In iOS 8 and
the older iOS, the property of delegate of UIScrollView is assign, so we
must set it to nil manually when object deallocated. And in iOS 9 and later
iOS, apple change the delegate property of UIScrollView it to weak, so we
don't set it to nil value any more. For compatibility on iOS 8, here we must
set it to nil value.
Bug: 94