New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-96][iOS] bug-fix about timer exposed on JSContext #839

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
3 participants
@acton393
Member

acton393 commented Nov 7, 2017

In most case , element in cell will be re-use for memory especially in very
long list, but if add event for this element, here will generate a new view for
this element,if it's nil due to a getter method whether it is off-screen.

For instance, image element in cell will re-use if it is disappear in vision area,
loaded again while it back to visual area. In this case , when it disappear, just
add event such as click, touch and so on , it will then create a new view,
and load image again, although it is off-screen.

If the view is not loaded, so won't add gesture or call this view getter to create
any view until the view is loaded, then it will init events according to record in
component.

Bug: 98

[WEEX-96][iOS] bug-fix about timer exposed on JSContext
  Timer exposed on the JSContext, so user can access the function,
though JavaScript, it has setTimeout and setInterval functions, those
function switch to global queue while execute javaScript code, it may
have potential crash about thread safe problem, and for setInterval
function, the timeId can not auto-increment, so it is hard to clear it at
the end of program.
  Overview the code, the difference between timer module and the
JSConext timer is  the execution path is more shorter, the JSContext
timer can execute javascript function immediately, but the timer module
instruction must be dispatched by weex sdk just like the common modules,
the JSContext can be used in canvas scene.

Bug: 96
@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Nov 7, 2017

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

weex-bot commented Nov 7, 2017

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

@asfgit asfgit merged commit 45c6c7e into apache:master Nov 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@acton393 acton393 deleted the acton393:ios-bugfix-timer-exposed-in-JSContext branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment