This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-96][iOS] bug-fix about timer exposed on JSContext #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer exposed on the JSContext, so user can access the function, though JavaScript, it has setTimeout and setInterval functions, those function switch to global queue while execute javaScript code, it may have potential crash about thread safe problem, and for setInterval function, the timeId can not auto-increment, so it is hard to clear it at the end of program. Overview the code, the difference between timer module and the JSConext timer is the execution path is more shorter, the JSContext timer can execute javascript function immediately, but the timer module instruction must be dispatched by weex sdk just like the common modules, the JSContext can be used in canvas scene. Bug: 96
Generated by 🚫 dangerJS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most case , element in cell will be re-use for memory especially in very
long list, but if add event for this element, here will generate a new view for
this element,if it's nil due to a getter method whether it is off-screen.
For instance, image element in cell will re-use if it is disappear in vision area,
loaded again while it back to visual area. In this case , when it disappear, just
add event such as click, touch and so on , it will then create a new view,
and load image again, although it is off-screen.
If the view is not loaded, so won't add gesture or call this view getter to create
any view until the view is loaded, then it will init events according to record in
component.
Bug: 98