New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-99][iOS] fix setViewport: sometimes doesn't work #843

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
4 participants
@myeveryheart
Contributor

myeveryheart commented Nov 8, 2017

[WEEX-99][iOS] fix setViewport: sometimes doesn't work.

The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

Bug:99

@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Nov 8, 2017

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

weex-bot commented Nov 8, 2017

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

@myeveryheart myeveryheart reopened this Nov 8, 2017

@asfgit asfgit merged commit c6b8a28 into apache:master Nov 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment