New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-105][iOS] bug-fix about setting nan frame crash #853

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
3 participants
@acton393
Member

acton393 commented Nov 13, 2017

try to protect nan crash when set frame containing nan value.
Last Exception Backtrace:

0   CoreFoundation                  0x00000001830301c0 __exceptionPreprocess :124 (in CoreFoundation)
1   libobjc.A.dylib                 0x0000000181a6855c _objc_exception_throw :56 (in libobjc.A.dylib)
2   CoreFoundation                  0x0000000183030108 +[NSException raise:format:] :116 (in CoreFoundation)
3   QuartzCore                      0x0000000186335db8 CA::Layer::set_position(CA::Vec2 const&, bool) :152 (in QuartzCore)
4   QuartzCore                      0x0000000186335f2c -[CALayer setPosition:] :40 (in QuartzCore)
5   QuartzCore                      0x00000001863364c4 -[CALayer setFrame:] :448 (in QuartzCore)
6   UIKit                           0x0000000188e71e2c -[UIView(Geometry) setFrame:] :784 (in UIKit)
7   Taobao4iPhone                   0x0000000102d6ad4c _43-[WXComponent(Layout) _frameDidCalculated:]_block_invoke WXComponent+Layout.m:136

Last Exception Backtrace 2:

0   CoreFoundation                  0x0000000185b12fe0 __exceptionPreprocess :124 (in CoreFoundation)
1   libobjc.A.dylib                 0x0000000184574538 _objc_exception_throw :56 (in libobjc.A.dylib)
2   CoreFoundation                  0x0000000185b12f28 +[NSException raise:format:] :116 (in CoreFoundation)
3   QuartzCore                      0x0000000188e29798 CA::Layer::set_bounds(CA::Rect const&, bool) :204 (in QuartzCore)
4   QuartzCore                      0x0000000188e299e0 -[CALayer setBounds:] :100 (in QuartzCore)
5   UIKit                           0x000000018bc908c8 -[UIView(Geometry) setBounds:] :404 (in UIKit)
6   UIKit                           0x000000018bc9eacc -[UIScrollView setBounds:] :988 (in UIKit)
7   UIKit                           0x000000018bd271c8 -[UITableView setBounds:] :224 (in UIKit)
8   UIKit                           0x000000018bc62828 -[UIScrollView setContentOffset:] :400 (in UIKit)
9   UIKit                           0x000000018bd191dc -[UITableView setContentOffset:] :272 (in UIKit)
10  Taobao4iPhone                   0x0000000102d7b6e8 -[WXTableView setContentOffset:] WXListComponent.m:63 (in Taobao4iPhone)
11  UIKit                           0x000000018bde6d08 -[UIScrollView _updatePanGesture] :1988 (in UIKit)
12  UIKit                           0x000000018c2168d0 -[UIGestureRecognizerTarget _sendActionWithGestureRecognizer:] :64 (in UIKit)
13  UIKit                           0x000000018c21a104 _UIGestureRecognizerSendTargetActions :124 (in UIKit)
14  UIKit                           0x000000018bdd40b4 _UIGestureRecognizerSendActions :252 (in UIKit)

Bug: 105

[WEEX-105][iOS] bug-fix about setting nan frame crash
try to protect nan crash when set frame containing nan value.
Last Exception Backtrace:
0   CoreFoundation                  0x00000001830301c0 __exceptionPreprocess :124 (in CoreFoundation)
1   libobjc.A.dylib                 0x0000000181a6855c _objc_exception_throw :56 (in libobjc.A.dylib)
2   CoreFoundation                  0x0000000183030108 +[NSException raise:format:] :116 (in CoreFoundation)
3   QuartzCore                      0x0000000186335db8 CA::Layer::set_position(CA::Vec2 const&, bool) :152 (in QuartzCore)
4   QuartzCore                      0x0000000186335f2c -[CALayer setPosition:] :40 (in QuartzCore)
5   QuartzCore                      0x00000001863364c4 -[CALayer setFrame:] :448 (in QuartzCore)
6   UIKit                           0x0000000188e71e2c -[UIView(Geometry) setFrame:] :784 (in UIKit)
7   Taobao4iPhone                   0x0000000102d6ad4c _43-[WXComponent(Layout) _frameDidCalculated:]_block_invoke WXComponent+Layout.m:136

Last Exception Backtrace 2:
0   CoreFoundation                  0x0000000185b12fe0 __exceptionPreprocess :124 (in CoreFoundation)
1   libobjc.A.dylib                 0x0000000184574538 _objc_exception_throw :56 (in libobjc.A.dylib)
2   CoreFoundation                  0x0000000185b12f28 +[NSException raise:format:] :116 (in CoreFoundation)
3   QuartzCore                      0x0000000188e29798 CA::Layer::set_bounds(CA::Rect const&, bool) :204 (in QuartzCore)
4   QuartzCore                      0x0000000188e299e0 -[CALayer setBounds:] :100 (in QuartzCore)
5   UIKit                           0x000000018bc908c8 -[UIView(Geometry) setBounds:] :404 (in UIKit)
6   UIKit                           0x000000018bc9eacc -[UIScrollView setBounds:] :988 (in UIKit)
7   UIKit                           0x000000018bd271c8 -[UITableView setBounds:] :224 (in UIKit)
8   UIKit                           0x000000018bc62828 -[UIScrollView setContentOffset:] :400 (in UIKit)
9   UIKit                           0x000000018bd191dc -[UITableView setContentOffset:] :272 (in UIKit)
10  Taobao4iPhone                   0x0000000102d7b6e8 -[WXTableView setContentOffset:] WXListComponent.m:63 (in Taobao4iPhone)
11  UIKit                           0x000000018bde6d08 -[UIScrollView _updatePanGesture] :1988 (in UIKit)
12  UIKit                           0x000000018c2168d0 -[UIGestureRecognizerTarget _sendActionWithGestureRecognizer:] :64 (in UIKit)
13  UIKit                           0x000000018c21a104 _UIGestureRecognizerSendTargetActions :124 (in UIKit)
14  UIKit                           0x000000018bdd40b4 _UIGestureRecognizerSendActions :252 (in UIKit)

Bug: 105
@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Nov 13, 2017

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

weex-bot commented Nov 13, 2017

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

@asfgit asfgit merged commit 784fd75 into apache:master Nov 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@acton393 acton393 deleted the acton393:bug-fix-setframe-nan-crash branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment