This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-109][iOS] add scrollstart and scrollend event's interface for scroller #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
cxfeng1-zz
suggested changes
Nov 13, 2017
| @@ -569,6 +573,8 @@ - (void)scrollViewDidEndScrollingAnimation:(UIScrollView *)scrollView | |||
| } | |||
|
|
|||
| [scrollView setContentInset:inset]; | |||
| [self fireEvent:@"scrollend" params:nil domChanges:nil]; | |||
|
|
|||
|
@doumafang Can you provide some examples of the pull request and please make sure the behavior on iOS is consistent with Android. |
acton393
approved these changes
Nov 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WEEX-109] [iOS] add scrollstart and scrollend event's interface for scroller
Just use fireEvent to make UIScrollViewDelegate exposed to the front users.
Now can use 'scrollstart' and 'scrollend' to get scroller's status.
https://issues.apache.org/jira/browse/WEEX-109
http://dotwe.org/vue/96421f059fb7481faa4af86adb813efa
http://dotwe.org/vue/30fce705bf5c8a0763a95367c9b8dcfe