New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-172][android] improve jsservice useage,support mutil type params #941

Closed
wants to merge 1 commit into
base: v0.17
from

Conversation

Projects
None yet
3 participants
@lybeen
Contributor

lybeen commented Dec 14, 2017

  1. modify register jsservice options type to Object, thus can pass whatever type params
  2. modify jsservice script to support js object
  3. add method getService
@weex-bot

This comment has been minimized.

weex-bot commented Dec 14, 2017

Messages
📖 android test finished.

Generated by 🚫 dangerJS

@zshshr

This comment has been minimized.

Contributor

zshshr commented Dec 15, 2017

take care of that Changing the parameter type of public Api may cause problem of compatibility

@zshshr

zshshr approved these changes Dec 15, 2017

@lybeen lybeen changed the title from [android] m jsservice register && jsservice options to [WEEX-172][android] m jsservice register && jsservice options Dec 15, 2017

@lybeen lybeen changed the title from [WEEX-172][android] m jsservice register && jsservice options to [WEEX-172][android] improve jsservice useage,support mutil type params Dec 15, 2017

@asfgit asfgit closed this in a90a1ed Dec 15, 2017

atomtong pushed a commit to atomtong/incubator-weex that referenced this pull request Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment