Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple HudiClient and OneTableClient #8

Closed
Tracked by #7
ashvina opened this issue Sep 5, 2023 · 0 comments · Fixed by #9
Closed
Tracked by #7

Decouple HudiClient and OneTableClient #8

ashvina opened this issue Sep 5, 2023 · 0 comments · Fixed by #9

Comments

@ashvina
Copy link
Contributor

ashvina commented Sep 5, 2023

No description provided.

@ashvina ashvina mentioned this issue Sep 5, 2023
Closed
5 tasks
ashvina added a commit that referenced this issue Sep 5, 2023
@ashvina
Decouple HudiClient and OneTableClient for extensibility
e7411df 
Fixes #8

This commit refactors the code to enhance onetable extensibility towards building a universal converter. Currently, the source client is hardcoded to be a HudiClient. And target clients were selected from a predetermined enumeration of TableFormats. The list of supported table formats and their versions needs to be flexible. Moreover users need to have ability to override default implementations.
With this change, list of table format clients and their implementation can be managed via a config file, allowing for easier addition or modification without a complete rebuild. Due to the dynamic nature of client types, RunSync and OneTableClient have been made generic.
Additionally, the target client interface has been streamlined by removing unused generics.
Lastly, some naming inconsistencies between using 'target' and 'sync' interchangeably for referring to target tables have been addressed, by calling them 'target' to match with 'source'.
@ashvina ashvina linked a pull request Sep 5, 2023 that will close this issue
Decouple HudiClient and OneTableClient for extensibility #9
Merged
@ashvina ashvina mentioned this issue Sep 5, 2023
Merged
ashvina added a commit that referenced this issue Sep 13, 2023
@ashvina
Decouple HudiClient and OneTableClient for extensibility (#9)
e0ff191 
Fixes #8

This commit refactors the code to enhance onetable extensibility towards building a universal converter. Currently, the source client is hardcoded to be a HudiClient. And target clients were selected from a predetermined enumeration of TableFormats. The list of supported table formats and their versions needs to be flexible. Moreover, users need to have ability to override default implementations.
With this change, list of table format clients and their implementation can be managed via a config file, allowing for easier addition or modification without a complete rebuild. Due to the dynamic nature of client types, RunSync and OneTableClient have been made generic.
Additionally, the target client interface has been streamlined by removing unused generics.
Lastly, some naming inconsistencies between using 'target' and 'sync' interchangeably for referring to target tables have been addressed, by calling them 'target' to match with 'source'.
Updated Readme documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decouple HudiClient and OneTableClient for extensibility apache/incubator-xtable
1 participant
@ashvina