[YUNIKORN-25] Logging improvements #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @wilfred-s |
wilfred-s
requested changes
Apr 15, 2020
pkg/cache/cluster_info.go
Outdated
| @@ -562,7 +562,14 @@ func (m *ClusterInfo) processAllocationProposalEvent(event *cacheevent.Allocatio | |||
| RejectedAllocations: event.AllocationProposals[:1], | |||
| }) | |||
| return | |||
| } else { | |||
There was a problem hiding this comment.
there is no need for an else clause.
logging should be outside
| @@ -109,7 +106,8 @@ func (manager partitionManager) cleanQueues(schedulingQueue *SchedulingQueue) { | |||
| } | |||
| } else { | |||
| // TODO time out waiting for draining and removal | |||
| log.Logger().Debug("failed to remove scheduling queue due to existing assigned apps or leaf queues", | |||
| log.Logger().Debug("skip removing the scheduling queue", | |||
| zap.String("reason", "there are existing assigned apps or leaf queues"), | |||
There was a problem hiding this comment.
we have not used this setup anywhere splitting message into two, not sure about this but don't mind it either
pkg/scheduler/scheduler.go
Outdated
Comment on lines
579
to
583
| if alloc != nil { | ||
| log.Logger().Debug("try to allocate resources for a request from a reservation", | ||
| zap.String("allocation", alloc.String())) | ||
| } | ||
|
|
There was a problem hiding this comment.
this is already logged in the scheduling_queue.tryReservedAllocate()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve logging messages