Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-541] Unexpected WARN log in node.go#refreshAvailableResource #248

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-541] Unexpected WARN log in node.go#refreshAvailableResource #248

wants to merge 1 commit into from

Conversation

TaoYang526
Copy link
Contributor

No description provided.

@TaoYang526 TaoYang526 changed the title [YUNIKORN-541] Unexpected warn log in node.go#refreshAvailableResource [YUNIKORN-541] Unexpected WARN log in node.go#refreshAvailableResource Feb 7, 2021
@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

Merging #248 (4e6a27a) into master (5a1c19e) will increase coverage by 0.29%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   63.46%   63.76%   +0.29%     
==========================================
  Files          60       60              
  Lines        5220     5265      +45     
==========================================
+ Hits         3313     3357      +44     
- Misses       1747     1750       +3     
+ Partials      160      158       -2
Impacted Files Coverage Δ
pkg/scheduler/context.go 6.28% <0.00%> (+0.01%) ⬆️
pkg/scheduler/objects/application.go 48.73% <0.00%> (-0.18%) ⬇️
pkg/scheduler/partition.go 65.94% <69.23%> (-0.11%) ⬇️
pkg/scheduler/objects/node.go 81.98% <75.00%> (+0.16%) ⬆️
pkg/webservice/handlers.go 56.73% <90.90%> (+2.59%) ⬆️
pkg/common/resources/resources.go 96.22% <94.28%> (+0.19%) ⬆️
pkg/common/configs/configvalidator.go 90.00% <100.00%> (+2.99%) ⬆️
pkg/scheduler/objects/application_state.go 95.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc601d7...4e6a27a. Read the comment docs.

@wilfred-s wilfred-s self-requested a review February 8, 2021 10:39
@wilfred-s wilfred-s added this to the 0.10.0 milestone Feb 8, 2021
wilfred-s
wilfred-s approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I thought we had already fixed this one earlier but I must be wrong

@wilfred-s wilfred-s closed this in d41a7d7 Feb 8, 2021
wilfred-s pushed a commit that referenced this pull request Feb 8, 2021
@TaoYang526 @wilfred-s
[YUNIKORN-541] Unexpected WARN log on node refresh (#248)
59b0cd2 
When a node's resources are updated a warning should be logged when the
node is over allocated after the update. The warning is incorrectly
logged in the case that the update is OK.

Fixes: #248
craigcondit pushed a commit to craigcondit/yunikorn-core that referenced this pull request Sep 20, 2021
@TaoYang526 @wilfred-s
[YUNIKORN-541] Unexpected WARN log on node refresh (apache#248)
cb69be5 
When a node's resources are updated a warning should be logged when the
node is over allocated after the update. The warning is incorrectly
logged in the case that the update is OK.

Fixes: apache#248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfred-s wilfred-s wilfred-s approved these changes

Assignees

@TaoYang526 TaoYang526

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TaoYang526 @wilfred-s