YUNIKORN-158. Admission controller deployment file should use the same image version as the scheduler #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e version as the scheduler.
|
@TaoYang526 , @sunilgovind could you help to review this? |
TaoYang526
requested changes
May 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 54.71% 54.71%
=======================================
Files 29 30 +1
Lines 2811 2811
=======================================
Hits 1538 1538
Misses 1215 1215
Partials 58 58
Continue to review full report at Codecov.
|
wilfred-s
added a commit
that referenced
this pull request
May 22, 2020
The change does not fix the image for the scheduler and causes the make to complain about unknown settings. This reverts commit ce2af05.
ayubpathan
pushed a commit
to ayubpathan/incubator-yunikorn-k8shim
that referenced
this pull request
Jun 10, 2020
…me image version as the scheduler (apache#117) Fixes: apache#117
ayubpathan
pushed a commit
to ayubpathan/incubator-yunikorn-k8shim
that referenced
this pull request
Jun 10, 2020
The change does not fix the image for the scheduler and causes the make to complain about unknown settings. This reverts commit ce2af05.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the hardcoded value and make sure the version is always aligned