Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-895] Update dependencies to latest master versions #343

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

@craigcondit craigcondit commented Dec 14, 2021

What is this PR for?

Update dependencies in master for core and scheduler-interface. This is necessary for 0.12 as well as to fix e2e test failures.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-895

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

go.mod Outdated Show resolved Hide resolved
@craigcondit craigcondit marked this pull request as draft December 14, 2021 01:42
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #343 (d7d8814) into master (c47ed51) will increase coverage by 1.87%.
The diff coverage is 64.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   59.75%   61.62%   +1.87%     
==========================================
  Files          35       39       +4     
  Lines        3133     5160    +2027     
==========================================
+ Hits         1872     3180    +1308     
- Misses       1180     1874     +694     
- Partials       81      106      +25     
Impacted Files Coverage Δ
pkg/cache/amprotocol_mock.go 0.00% <0.00%> (ø)
pkg/cache/context_recovery.go 40.67% <0.00%> (-5.67%) ⬇️
pkg/common/events/recorder_mock.go 0.00% <0.00%> (ø)
pkg/common/events/states.go 0.00% <0.00%> (ø)
pkg/shim/main.go 0.00% <0.00%> (ø)
...missioncontrollers/webhook/admission_controller.go 30.41% <7.79%> (-2.33%) ⬇️
pkg/appmgmt/appmgmt_recovery.go 67.92% <16.66%> (-7.76%) ⬇️
pkg/cache/context.go 37.82% <19.29%> (-3.26%) ⬇️
pkg/common/events/recorder.go 40.00% <28.57%> (+10.00%) ⬆️
pkg/cache/nodes.go 78.28% <46.15%> (-1.52%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d0509...d7d8814. Read the comment docs.

@craigcondit craigcondit marked this pull request as ready for review December 14, 2021 16:20
@craigcondit
Copy link
Contributor Author

@yuchaoran2011 can you review?

Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @craigcondit Could you also commit this change to branch-0.12?

@craigcondit
Copy link
Contributor Author

Yes, I will commit to both branches shortly.

@craigcondit craigcondit deleted the YUNIKORN-891 branch December 14, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants