Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-12] when pod.Name is empty, admission-controller generates weird IDs #79

Merged
merged 1 commit into from
Mar 4, 2020
Merged

[YUNIKORN-12] when pod.Name is empty, admission-controller generates weird IDs #79

merged 1 commit into from
Mar 4, 2020

Conversation

yangwwei
Copy link
Contributor

pod.Name could be empty, because some names are generated by GenerateName flag.

@yangwwei yangwwei self-assigned this Feb 29, 2020
@yangwwei yangwwei changed the title when pod.Name is empty, admission-controller generates weird IDs [YUNIKORN-12] when pod.Name is empty, admission-controller generates weird IDs Mar 4, 2020
wilfred-s
wilfred-s approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@wilfred-s wilfred-s merged commit 99f3c11 into master Mar 4, 2020
@wilfred-s wilfred-s deleted the admission branch March 4, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfred-s wilfred-s wilfred-s approved these changes

Assignees

@yangwwei yangwwei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangwwei @wilfred-s