Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-447] Standardized Version Variables #449

Merged
merged 5 commits into from
Jun 25, 2022
Merged

[INLONG-447] Standardized Version Variables #449

merged 5 commits into from
Jun 25, 2022

Conversation

bluewang
Copy link
Contributor

Fixes #447

where XYZ should be replaced by the actual issue number.

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

leezng
leezng reviewed Jun 24, 2022
View reviewed changes
docs/version.js Outdated Show resolved Hide resolved
versioned_docs/version-1.2.0/version.js Outdated Show resolved Hide resolved
@healchow healchow self-requested a review June 24, 2022 10:43
@dockerzhang dockerzhang merged commit e823156 into apache:master Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leezng leezng leezng left review comments

@gong gong gong approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@yunqingmoswu yunqingmoswu yunqingmoswu approved these changes

@healchow healchow Awaiting requested review from healchow

Assignees

@bluewang bluewang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][Website] Standardized Version Variables
6 participants
@bluewang @gong @leezng @dockerzhang @healchow @yunqingmoswu