Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-781][Doc][SqlServer] Describe tables using MarkDown #785

Merged
merged 3 commits into from
Jun 28, 2023
Merged

[INLONG-781][Doc][SqlServer] Describe tables using MarkDown #785

merged 3 commits into from
Jun 28, 2023

Conversation

e-mhui
Copy link
Contributor

@e-mhui e-mhui commented Jun 27, 2023

Prepare a Pull Request

[INLONG-781][Doc][SqlServer] Describe tables using MarkDown

Motivation

[INLONG-781][Doc][SqlServer] Describe tables using MarkDown

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@dockerzhang dockerzhang requested a review from gong June 27, 2023 14:52
@dockerzhang dockerzhang merged commit 40fdf83 into apache:master Jun 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockerzhang dockerzhang dockerzhang approved these changes

@EMsnap EMsnap EMsnap approved these changes

@yunqingmoswu yunqingmoswu yunqingmoswu approved these changes

@gong gong Awaiting requested review from gong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][Doc][SqlServer] Describe tables using MarkDown
4 participants
@e-mhui @dockerzhang @EMsnap @yunqingmoswu