[INLONG-7421][Manager] Add encoding check to the MySQL JDBC URL in My…

…SQLDataNode (#7422)
apache · Feb 24, 2023 · 1ec9289 · 1ec9289
1 parent 34a7e8f
commit 1ec9289
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...anager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/mysql/MySQLDataNodeDTO.java b/...anager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/mysql/MySQLDataNodeDTO.java
@@ -27,6 +27,7 @@
 import org.apache.inlong.manager.common.enums.ErrorCodeEnum;
 import org.apache.inlong.manager.common.exceptions.BusinessException;
 import org.apache.inlong.manager.common.util.JsonUtils;
+import org.apache.inlong.manager.pojo.sink.mysql.MySQLSinkDTO;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -77,6 +78,6 @@ public static String convertToJdbcurl(String url) {
         if (StringUtils.isNotBlank(jdbcUrl) && !jdbcUrl.startsWith(MYSQL_JDBC_PREFIX)) {
             jdbcUrl = MYSQL_JDBC_PREFIX + jdbcUrl;
         }
-        return jdbcUrl;
+        return MySQLSinkDTO.filterSensitive(jdbcUrl);
     }
 }
diff --git a/...er/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/mysql/MySQLSinkDTO.java b/...er/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/mysql/MySQLSinkDTO.java
@@ -17,7 +17,6 @@
 
 package org.apache.inlong.manager.pojo.sink.mysql;
 
-import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Strings;
 import io.swagger.annotations.ApiModelProperty;
 import lombok.AllArgsConstructor;
@@ -217,8 +216,7 @@ public static String setDbNameToUrl(String jdbcUrl, String databaseName) {
      * @param url str may have some sensitive params
      * @return str without sensitive param
      */
-    @VisibleForTesting
-    protected static String filterSensitive(String url) {
+    public static String filterSensitive(String url) {
         if (StringUtils.isBlank(url)) {
             return url;
         }