[INLONG-9328][Manager] Add parameters validation for the updateAuditS…

…ource method
apache · Nov 23, 2023 · 1edaf8b · 1edaf8b
1 parent 581444a
commit 1edaf8b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/...r/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/audit/AuditSourceRequest.java b/...r/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/audit/AuditSourceRequest.java
@@ -25,6 +25,7 @@
 import lombok.NoArgsConstructor;
 
 import javax.validation.constraints.NotBlank;
+import javax.validation.constraints.Pattern;
 
 /**
  * Audit source request
@@ -45,6 +46,7 @@ public class AuditSourceRequest {
     private String type;
 
     @NotBlank
+    @Pattern(regexp = "^(jdbc:(mysql|clickhouse)://[\\w.]+(:\\d+)?/[\\w]+(\\?.*)?|http://[\\w.]+(:\\d+)?(/[\\w]+)+(/\\d+(-\\d+)?(,\\d+(-\\d+)?)*)?)", message = "only supports MYSQL, CLICKHOUSE, ELASTICSEARCH url")
     @ApiModelProperty(value = "Audit source URL, for MYSQL or CLICKHOUSE, is jdbcUrl, and for ELASTICSEARCH is the access URL with hostname:port", required = true)
     private String url;
 

diff --git a/...r/manager-web/src/main/java/org/apache/inlong/manager/web/controller/AuditController.java b/...r/manager-web/src/main/java/org/apache/inlong/manager/web/controller/AuditController.java
@@ -65,7 +65,7 @@ public Response<Boolean> refreshCache() {
 
     @ApiOperation(value = "Update the audit source")
     @PostMapping(value = "/audit/updateSource")
-    public Response<Integer> updateAuditSource(@RequestBody AuditSourceRequest request) {
+    public Response<Integer> updateAuditSource(@Valid @RequestBody AuditSourceRequest request) {
         return Response.success(auditService.updateAuditSource(request, LoginUserUtils.getLoginUser().getName()));
     }