Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella][Manager] Unify the InlongGroup workflow #5029

Closed
7 tasks done
healchow opened this issue Jul 14, 2022 · 1 comment
Closed
7 tasks done

[Umbrella][Manager] Unify the InlongGroup workflow #5029

healchow opened this issue Jul 14, 2022 · 1 comment
Assignees
Milestone

Comments

@healchow
Copy link
Member

healchow commented Jul 14, 2022

Describe the proposal

Unify the InlongGroup workflow.

Combining the processes of Lightweight and Standard together, most of the processing logic can be reused.

image

For processes that need to distinguish between Lightweight and Standard, the configuration of InlongGroup can be used to distinguish them.

image

[Benefit]

  1. Improve code reusability, thereby reducing maintenance costs.

  2. Simplify the processing logic of various Listeners - the workflow only needs to be dispatched to the relevant processing Listeners, and the specific execution logic is handed over to the specific executor of this Listener to execute.

    For example, to create a Listener of a sink resource, you only need to hold the factory of the implementation class that creates the sink resource. At runtime, the instance is obtained according to the specific type, and the creation process can be implemented by it (such as the Hive library table).
    Otherwise, each type of Sink must implement a Listener…

  3. Improve scalability: When other users use this process, they only need to implement the interfaces in the above factories, and they can expand the intranet process without changing the source code of Inlong-Manager.

Task list

InLong Component

InLong Manager

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@healchow
Copy link
Member Author

healchow commented Aug 3, 2022

All sub-issues were resolved.

@healchow healchow closed this as completed Aug 3, 2022
@healchow healchow added this to the 1.3.0 milestone Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant