Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][TubeMQ] compile error with gcc >= 8.0 on rapidjson #5138

Closed
1 of 2 tasks
zhz365365 opened this issue Jul 20, 2022 · 5 comments · Fixed by #5151
Closed
1 of 2 tasks

[Bug][TubeMQ] compile error with gcc >= 8.0 on rapidjson #5138

zhz365365 opened this issue Jul 20, 2022 · 5 comments · Fixed by #5151
Assignees
Labels
Milestone

Comments

@zhz365365
Copy link

What happened

when use gcc8.3.1, the compile for rapidjson exist error
企业微信截图_b2913025-d43c-4e06-9bf7-85b125b70564

What you expected to happen

fix it on gcc version >= 8.0

How to reproduce

compile it on protobuf.3.6.1 and gcc.8.3.1

Environment

protobuf.3.6.1 and gcc.8.3.1

InLong version

master

InLong Component

InLong SDK

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@zhz365365 zhz365365 added the type/bug Something is wrong label Jul 20, 2022
@github-actions
Copy link

Thanks a lot for opening your first issue with us! 🧡 We'll get back to you shortly! ⏳

@gosonzhang
Copy link
Contributor

@zhz365365, this should not be a problem of implementation. After the problem was solved, how did you deal with it?

@zhz365365
Copy link
Author

zhz365365 commented Jul 20, 2022

@zhz365365, this should not be a problem of implementation. After the problem was solved, how did you deal with it?

We fix it by add -Wno-error=class-memaccess on the CMAKE_CXX_FLAGS in CMakeLists.txt file, referenced on https://www.linuxquestions.org/questions/slackware-14/failing-to-build-rapidjson-and-libxkbcommon-on-slackware-arm-current-4175647470/

@gosonzhang
Copy link
Contributor

@zhz365365, thanks!

@gosonzhang gosonzhang self-assigned this Jul 21, 2022
@gosonzhang gosonzhang changed the title [Bug][compile error with gcc >= 8.0 on rapidjson] [Bug][TubeMQ] compile error with gcc >= 8.0 on rapidjson Jul 21, 2022
@gosonzhang
Copy link
Contributor

image

Based on the modification method of @zhz365365, I added the GCC version judgment in CMakeList. Since the environment only encountered 8.3.1, I only made a rough judgment on 8.0.0. If you find that a more refined version also needs this in practice, please submit an issue for modification.

After verification in GCC 8.3.1 and 4.8.1 environments, the problem is solved.

Thanks to @charlely for her help and guidance.

@healchow healchow added this to the 1.3.0 milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants