Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][DataProxy] Adjust the fields statistics unit in DataProxyMetricItemSet #6012

Closed
2 tasks done
gosonzhang opened this issue Sep 23, 2022 · 0 comments · Fixed by #6013
Closed
2 tasks done

[Bug][DataProxy] Adjust the fields statistics unit in DataProxyMetricItemSet #6012

gosonzhang opened this issue Sep 23, 2022 · 0 comments · Fixed by #6013
Assignees
Labels
Milestone

Comments

@gosonzhang
Copy link
Contributor

What happened

The parent issue is:#5888

In the DataProxyMetricItemSet object, the units of the fields readSuccessCount, readFailCount, sendCount, sendSuccessCount, and sendFailCount are the number of message items[1], not the number of packets. The current implementation is based on the number of packets[2], which needs to be aligned.

  1. https://inlong.apache.org/docs/next/modules/dataproxy/overview/
    image

  2. https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/metrics/DataProxyMetricItemSet.java#L137
    image

What you expected to happen

the count of message items, not packages

How to reproduce

run and test

Environment

Linux

InLong version

master

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants