Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella][DataProxy] Uniform data field key name #5888

Closed
2 tasks done
gosonzhang opened this issue Sep 14, 2022 · 2 comments
Closed
2 tasks done

[Umbrella][DataProxy] Uniform data field key name #5888

gosonzhang opened this issue Sep 14, 2022 · 2 comments
Assignees
Labels
component/dataproxy stage/stale Issues or PRs that had no activity for a long time type/umbrella

Comments

@gosonzhang
Copy link
Contributor

Description

The parent issue is: #5745
In DataProxy, there are many value pairs of key=value, but in the whole system, keys with the same meaning use different names, such as the same groupId, some are groupId, some are inlongGroupId, and all of them are passed to the backend nodes, which will make the back-end components implement a lot of compatible code logic. This kind of problem is purely caused by the inconstant keys.

For these problems, in order to avoid too many modifications affecting the original logic, this issue, as the parent issue, will be modified for each key bill of lading one by one.

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stage/stale Issues or PRs that had no activity for a long time label Nov 14, 2022
@gosonzhang
Copy link
Contributor Author

This issue is finished

@healchow healchow changed the title [Improve][DataProxy] Uniform data field key name [Umbrella][DataProxy] Uniform data field key name Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dataproxy stage/stale Issues or PRs that had no activity for a long time type/umbrella
Projects
None yet
Development

No branches or pull requests

2 participants