Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][DataProxy] Use the defined message attribute key value in InLong-Common #6369

Closed
2 tasks done
gosonzhang opened this issue Nov 2, 2022 · 1 comment · Fixed by #6386
Closed
2 tasks done

Comments

@gosonzhang
Copy link
Contributor

Description

When dealing with pr[1], I found that DataProxy separately defines the property Key value for message interaction between SDK and DataProxy. This information should be placed in InLong-Common, so that when dealing with cross-module content, the same Key It can avoid repeated definitions, or the problem that the key value is defined incorrectly and the corresponding value cannot be obtained.

  1. [INLONG-6329][DataProxy] Add proxy-send mode message logic #6351

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@gosonzhang
Copy link
Contributor Author

gosonzhang commented Nov 3, 2022

I made the following changes in the PR (#6386) :

  1. Change all message attribute Keys generated by SDK and used by DataProxy or other modules to be obtained from org.apache.inlong.common.msg.AttributeConstants;
  2. The message attribute Key generated by DataProxy and returned to the receiver through the message attribute is placed in the org.apache.inlong.common.msg.AttributeConstants file, and the generation direction is marked;
  3. Change the file name of org.apache.inlong.dataproxy.consts.AttributeConstants to org.apache.inlong.dataproxy.consts.AttrConstants to avoid confusing references with the same name as org.apache.inlong.common.msg.AttributeConstants

@healchow healchow added this to the 1.4.0 milestone Nov 3, 2022
@healchow healchow changed the title [Improve][DataProxy] Use the defined message attribute Key value in InLong-Common [Improve][DataProxy] Use the defined message attribute key value in InLong-Common Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants