Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-6369][DataProxy] Use the defined message attribute Key value in InLong-Common #6386

Merged
merged 1 commit into from
Nov 3, 2022
Merged

[INLONG-6369][DataProxy] Use the defined message attribute Key value in InLong-Common #6386

merged 1 commit into from
Nov 3, 2022

Conversation

gosonzhang
Copy link
Contributor

@gosonzhang gosonzhang commented Nov 3, 2022 •
edited
Loading

Modifications:

  1. Change all message attribute Keys generated by SDK and used by DataProxy or other modules to be obtained from org.apache.inlong.common.msg.AttributeConstants;
  2. The message attribute Key generated by DataProxy and returned to the receiver through the message attribute is placed in the org.apache.inlong.common.msg.AttributeConstants file, and the generation direction is marked;
  3. Change the file name of org.apache.inlong.dataproxy.consts.AttributeConstants to org.apache.inlong.dataproxy.consts.AttrConstants to avoid confusing references with the same name as org.apache.inlong.common.msg.AttributeConstants

@gosonzhang gosonzhang mentioned this pull request Nov 3, 2022
Closed
2 tasks
@gosonzhang gosonzhang merged commit e97a2c2 into apache:master Nov 3, 2022
@gosonzhang gosonzhang deleted the INLONG-6369 branch November 3, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocozh pocozh pocozh approved these changes

@healchow healchow healchow approved these changes

@EMsnap EMsnap EMsnap approved these changes

Assignees
No one assigned
Labels
component/dataproxy component/sdk component/sort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][DataProxy] Use the defined message attribute key value in InLong-Common
4 participants
@gosonzhang @EMsnap @healchow @pocozh