Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][DataProxy] Clean up useless configuration files in the ConfigManager class #7898

Closed
2 tasks done
gosonzhang opened this issue Apr 23, 2023 · 0 comments · Fixed by #7899
Closed
2 tasks done

Comments

@gosonzhang
Copy link
Contributor

Description

Analyze the implementation of the ConfigManager class[1] and find that some configuration files do not need to be preserved:

  1. transfer.properties, not used in the system;
  2. dc_mapping.properties, tube_switch.properties, from the perspective of implementation, belong to some original code residues, and there is no document to define its usage, so it is not necessary to keep it;

In addition, for the unused blacklist.properties, it is very helpful for managing the reporting source on the access side. Personally, it needs to expand its use, it will not be deleted.

  1. https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/ConfigManager.java#L75

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants