Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1525]Fix bug which will cause Go SDK fail to parse SubscribeInfo #1526

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

TszKitLo40
Copy link
Contributor

@TszKitLo40 TszKitLo40 commented Sep 6, 2021

Signed-off-by: Zijie Lu wslzj40@gmail.com

Title Name: [INLONG-1525][component] Title of the pull request

where XYZ should be replaced by the actual issue number.

Fixes #1525

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #1526 (e70cf1c) into INLONG-25 (f2e773e) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             INLONG-25   #1526      +/-   ##
==============================================
+ Coverage         7.46%   7.51%   +0.04%     
- Complexity         477     479       +2     
==============================================
  Files              267     267              
  Lines            29500   29500              
  Branches          4843    4843              
==============================================
+ Hits              2203    2216      +13     
+ Misses           26830   26810      -20     
- Partials           467     474       +7     
Impacted Files Coverage Δ
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 43.98% <0.00%> (+1.46%) ⬆️
.../apache/tubemq/corebase/policies/FlowCtrlItem.java 38.88% <0.00%> (+2.22%) ⬆️
...pache/tubemq/corebase/policies/FlowCtrlResult.java 60.00% <0.00%> (+60.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2e773e...e70cf1c. Read the comment docs.

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit 11353eb into apache:INLONG-25 Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants